Ticket #279 (closed Enhancement: Fixed)

Opened 3 years ago

Last modified 11 months ago

progress bar needed when file are saved and/or SEAMCAT is closing down

Reported by: jean-philippe Owned by: mads.enevoldsen
Priority: Critical Milestone: 3.2.x - Beta - Pack 1
Component: General Seamcat Version: 3.2.0 Beta 12
Keywords: Cc: cp, jean-philippe
Blocked By: Blocking:
Estimated Number of Hours: 0 Pending: no
Add Hours to Ticket: 0 Total Hours: 0
Original Estimate: 0 Source (can be left blank):
Must be closed before next release: no Effort Required: Unknown

Description (last modified by jean-philippe) (diff)

Background: Currently, SEAMCAT waits for the file to close properly (i.e. a fix was found to avoid the workspaces to be truncated when SEAMCAT is shutting down.). However the users are not informed of what is happening when a file is being closed.

Requirement: The user should be made aware of what SEAMCAT does in the background when closing done or saving, so that the user does not have the feeling that SEAMCAT is hanging for ever. This is especially useful when the results are to be saved as it may take some time.

Proposal of implementation:

  • To implement a progress bar which would give feedback to the user when closing SEAMCAT.

  • Implement a progress bar, as shown below, when the file is being.

  • When the user is prompted if he wants to save the results, he should be informed of the <time estimate> in minutes to save the results.



Testing procedure:

  • Visual inspection with heavy file to save.

Attachments

fig1_279.gif Download (12.0 KB) - added by jean-philippe 17 months ago.
figure2_279.gif Download (8.8 KB) - added by jean-philippe 15 months ago.
figure3_279.gif Download (7.1 KB) - added by jean-philippe 15 months ago.

Change History

comment:1 Changed 3 years ago by DefaultCC Plugin

  • Cc cp, jean-philippe added

comment:2 Changed 3 years ago by jean-philippe

  • Description modified (diff)

comment:3 Changed 3 years ago by jean-philippe

  • Summary changed from progress bar when file are saved and/or SEAMCAT is closing down to progress bar needed when file are saved and/or SEAMCAT is closing down

comment:4 Changed 2 years ago by jean-philippe

  • Milestone changed from 3.2.0 Beta 16 to 3.2.0 Beta 15 - CR / Overload

comment:5 Changed 2 years ago by jean-philippe

  • Owner changed from cp to thomas.thorndal

comment:6 Changed 2 years ago by jean-philippe

  • Owner changed from thomas.thorndal to thomas.thorndahl

comment:7 Changed 2 years ago by jean-philippe

  • Milestone changed from 3.2.1 - beta - Cognitive Radio feature to 3.2.2 - Beta - miscellaneous

comment:8 Changed 23 months ago by jean-philippe

  • Priority changed from Major to Critical

comment:9 Changed 20 months ago by jean-philippe

  • Milestone changed from 3.2.3 - Beta - miscellaneous to 3.2.x - Beta - Pack 1

comment:10 Changed 17 months ago by jean-philippe

  • Description modified (diff)

Changed 17 months ago by jean-philippe

comment:11 Changed 15 months ago by jean-philippe

  • Owner changed from thomas.thorndahl to mads.enevoldsen

comment:12 Changed 15 months ago by jean-philippe

  • Description modified (diff)

comment:13 Changed 15 months ago by jean-philippe

  • Description modified (diff)

Changed 15 months ago by jean-philippe

Changed 15 months ago by jean-philippe

comment:14 Changed 15 months ago by jean-philippe

  • Description modified (diff)

comment:15 Changed 13 months ago by mads.enevoldsen

Fixed in [1075]

comment:16 Changed 13 months ago by jean-philippe

can you also include the estimated size, as we discussed, in the window dialog asking to save the file:

"The workspace contains results estimated to be higher than xx/units.
Do you whish to save these.
yes/no"

comment:17 Changed 13 months ago by mads.enevoldsen

Added estimate in [1079]. The numer grows with the formula where v is vector size and i is number of interferers: v*( i + 2(i+1) + (i*(i-1)) + 1).

This seems to be too high for increasing number of interferers, but I have difficulties testing it since I quickly get OutOfMemoryException?.

Preferable would be to re-write the save part not to build the large memory structure before saving.

comment:18 Changed 13 months ago by jean-philippe

Can you check that the fix also works when the user press "save workspace as"? ( it works for me when I press "save" but not save as.

Otherwise I agree that some refactoring is needed for this:

  • it is bad that the user reach out of memeory for saving and loading
  • it is also bad that when it crashes the user does not get any error message at save and load.

(I would need an estimate from your side on how long it would take)

comment:19 Changed 13 months ago by mads.enevoldsen

also estimating size when "Save as..." in [1080]

comment:20 Changed 13 months ago by jean-philippe

  • Status changed from new to closed
  • Resolution set to Fixed

tested. ticket is closed

comment:21 Changed 13 months ago by mads.enevoldsen

Centering the progress bar in [1112]

comment:22 Changed 11 months ago by mads.enevoldsen

eliminated hanging in [1210]

Note: See TracTickets for help on using tickets.